Status: ACCEPTED, 2026-11-06 (Arch-authored). This ADR records rulings already made and landed (decisions.log, 2026-10-30 to 2026-11-05) as one decision, so the next change to the offer set has a single place to read. It changes no code. Related issues: #2236, #2237, #2245, #2238, #2284, #1481, #2262. Law it serves: ADR-080 (code decides permission), ADR-081 (whose token serves a request).
The beta (outside testers from 2026-10-31) offers two connectors, GitHub and Google Calendar. Slack and Notion exist in the code, with routes, stored credentials and readers, but they are not offered. Within one week, four separate defects showed the same gap: each surface kept its own idea of what was offered.
A hand-kept list on each surface drifts, and each drift either offers something we don’t support or reads a credential we said we wouldn’t.
services/integrations/integration_status_service.py holds it:
offered_connectors() returns the host’s offered set;connector_offered(name) is the yes/no.The set is BETA_OFFERED_CONNECTORS (code-fixed, {"github", "calendar"} today), plus STAGING_ONLY_OFFERED_CONNECTORS when, and only when, FLY_APP_NAME == "piper-morgan-staging".
Rules:
FLY_APP_NAME is set per app at runtime, so a staging-only offer can’t travel (11-01 08:40).| Surface | Reads it how |
|---|---|
Connect, OAuth-start, OAuth-callback and credential-save routes (web/api/routes/settings_integrations.py, web/api/routes/setup.py) |
refuse_unless_offered(name) as the route body’s first statement: HTTP 409 with NOT_OFFERED_MESSAGE, before any redirect, validation or write (#2237, 10-30 20:50) |
Integrations page (templates/integrations.html) |
window.__OFFERED_CONNECTORS__ from web/api/routes/ui.py. The page’s OAUTH_INTEGRATIONS and API_KEY_INTEGRATIONS say only how a connector connects, and every use is behind isOffered. The page fails closed |
Chat capability reply and floor identity context (capability_answer.py, canonical_handlers.py) |
offered_connectors(), one key-based filter (#2245, 10-31 19:34; #2236, 10-30 19:05) |
Chat connect pointers (chat_pointers.py) |
connector_offered. A non-offered ask gets the pointer to what is offered (NOT_OFFERED_ALTERNATIVE) |
| Credential use-path reads (D3) | connector_offered |
A new surface that shows, guards or lists connectors reads the predicate. A surface that needs a connector’s kind (OAuth or API key) may keep that as data, but never as a second offer list.
Stored credentials survive a descope, because accounts connected before it. The gate sits at the connector’s one use-path read, not at each reader (#2284, 11-05 06:28; validated 10:41 on 865e06c3ba):
SlackConfigService.get_config(user_id) returns the config with bot_token and user_token blank when Slack isn’t offered. Readers then see “not connected” through the path they already handle (#2151). The socket-mode runner’s start returns no runner on such a host.connector_offered("notion").Named exceptions, which may read a non-offered credential:
disconnect.py) reads it to revoke and clear it. Disconnect routes never call refuse_unless_offered: a user may always clear a stale connection.integration_status_service) checks existence only, so the card can say Piper still holds a connection.A ratchet pins which modules may name the Slack keychain slots (TestSlackSlotRatchet).
To offer a connector for real:
BETA_OFFERED_CONNECTORS;STAGING_ONLY_OFFERED_CONNECTORS;Which connectors are offered is product scope (PPM and xian); this ADR fixes only how an offer takes effect.
TestNotionUserKeyGate), not by a ratchet. A Notion ratchet is the next tightening if a second Notion reader appears.tests/unit/services/integrations/test_offer_gate_1481_2238.py;tests/unit/services/integrations/test_offered_gate_credential_reads_2284.py;tests/unit/services/integrations/test_notion_hosted_user_key_2238.py.git grep for connector_offered|offered_connectors|refuse_unless_offered over services/ and web/ (2026-11-06) gives 8 refuse_unless_offered route sites and 10 other predicate calls, across 9 modules besides the definition.